Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dispatcher for sqrtm #53

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Add dispatcher for sqrtm #53

merged 3 commits into from
Jun 12, 2024

Conversation

rochisha0
Copy link
Contributor

Description
This PR aims to add dispatcher for sqrtm to jax.jit funtionality in qutip.core.metrics, a similar PR has also been in qutip

Note: jax.grad still does not work because there is no differentiation available in jax.grad for Schur decomposition

@@ -70,6 +70,12 @@ class TestInv(testing.TestInv):
specialisations = [pytest.param(_inv_jax, JaxArray, JaxArray)]


class TestExpm(testing.TestExpm):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update this line.

Copy link
Member

@Ericgig Ericgig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Ericgig
Copy link
Member

Ericgig commented Jun 12, 2024

Test failure due to deprecation in the new jax version...
New tests passes.

@Ericgig Ericgig merged commit db0fb39 into qutip:master Jun 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants