Added AWS Credentials to main.tf #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 20, 2020 16:44
…h credentials was found On branch master Changes: modified: AUTHORS.md - added myself :) modified: main.tf - added aws credentials to kubernetes_deployment.spec.container.env modified: variables.tf - added vars aws access key and secret modified: versions.tf - terraform 0.13update
On branch master modified: main.tf
koshkin-ccna
suggested changes
Nov 3, 2020
|
Bug fixes, better formated tf files. |
headcr4sh
requested changes
Nov 3, 2020
There was a problem hiding this comment.
First of all: Thank you very much for the PR!
Credentials should be optional, though. Example: In case of EKS and IAM based permissions, no AWS access key is required.
Same goes for setups that utilize kube2iam or kiam.
I see the use-case your PR tries to fit, though. I'll gladly merge it, once the access key variables are purely optional.
| @@ -407,6 +408,19 @@ resource "kubernetes_deployment" "this" { | |||
| "--aws-max-retries=10", | |||
| ] | |||
|
|
|||
| env { | |||
There was a problem hiding this comment.
A dynamic block with optional environment variables would be a cleaner solution, I think.
Any chance that this is possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the issue like kubernetes-sigs/aws-load-balancer-controller#601
And it was ok to add AWS credits to the env block of the container.
Now it works for me.