Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Exponential back off & Mask secrets from log #43

Merged
merged 11 commits into from
Sep 3, 2020

Conversation

svyotov
Copy link
Contributor

@svyotov svyotov commented Aug 26, 2020

  • Check if there are clone errors
  • Add newExponentialBackOff for clone operations (we have observed frequent DNS/network issues with GitHub - easy to recover from with a retry)
  • Mask the GitHub token from the log

@svyotov svyotov changed the title Exponential back off Exponential back off & Mask secrets from log Aug 26, 2020
@svyotov svyotov closed this Aug 26, 2020
@svyotov svyotov reopened this Aug 26, 2020
@svyotov
Copy link
Contributor Author

svyotov commented Aug 26, 2020

The fail is due to GitHub rate limit and not due to the PR to the best of my understanding.

Will close/reopen to force re-run.

It appears to be a Travis CI Mac OS API rate issue, similar post: actions/runner-images#602

@svyotov svyotov closed this Aug 26, 2020
@svyotov svyotov reopened this Aug 26, 2020
@svyotov svyotov closed this Aug 27, 2020
@svyotov svyotov reopened this Aug 27, 2020
@svyotov svyotov closed this Aug 27, 2020
@svyotov svyotov reopened this Aug 27, 2020
@svyotov svyotov closed this Aug 28, 2020
@svyotov svyotov reopened this Aug 28, 2020
@jorinvo
Copy link
Member

jorinvo commented Aug 31, 2020

Hi @svyotov, thanks for opening a PR for this! I would be happy to add the ability to retry on errors and use exponential back-off for this 🙂

There is only one issue I see with the current state of the PR: The PR introduces a 3rd-party dependency. For now ghbackup didn't need any 3rd-party library. Since exponential back-off is not a complex algorithm I would rather not introduce an external library for this. If you could change that, I would be happy to merge this :)

@svyotov
Copy link
Contributor Author

svyotov commented Aug 31, 2020

Hi @svyotov, thanks for opening a PR for this! I would be happy to add the ability to retry on errors and use exponential back-off for this slightly_smiling_face

There is only one issue I see with the current state of the PR: The PR introduces a 3rd-party dependency. For now ghbackup didn't need any 3rd-party library. Since exponential back-off is not a complex algorithm I would rather not introduce an external library for this. If you could change that, I would be happy to merge this :)

👍 done

ghbackup/run.go Outdated Show resolved Hide resolved
@jorinvo
Copy link
Member

jorinvo commented Sep 3, 2020

I would merge this now if you don't mind :)

@jorinvo jorinvo merged commit a7aeb9f into qvl:master Sep 3, 2020
@jorinvo
Copy link
Member

jorinvo commented Sep 3, 2020

ok, there is a new release now including this PR: https://github.com/qvl/ghbackup/releases/tag/v1.13.0

@svyotov svyotov deleted the exponential-back-off branch September 3, 2020 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants