Use [ instead of bash-specific [[ for test

[edwinbalani]

The '[[' test is a bash-specific builtin, so on systems where #!/usr/bin/env sh (the hashbang line) doesn't return a bash executable, you can get this error:

/usr/bin/git-fire: 52: /usr/bin/git-fire: [[: not found

In my case the script was running in dash, which doesn't have the builtin and aims for POSIX compliance over additional features.

The commit changes the test on line 52 to use the [ executable instead, and adds quotes around the $( ) expression for escaping.

[dyc3]

Why not change the shebang to #!/usr/bin/env bash then?

[edwinbalani]

Why not change the shebang to #!/usr/bin/env bash then?

Because that would make the script dependent on having bash installed. In 95% of cases that's probably a safe bet, but there will always be edge cases ;). Having a POSIX-compliant shell available at sh is essentially mandatory, though, so can be relied upon.

Also, [ was already being used in the script (see here) before the block containing the [[ was merged in #27.

[qw3rtman]

@edwinbalani, thank you for your contribution and comments. Portability (i.e: POSIX-compliance) is crucial.