chore: use slices.Clone to replace CloneSlice (pingcap#57317)

close pingcap#57316

br/pkg/streamhelper/advancer.go

@@ -6,6 +6,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"slices"
 	"strings"
 	"sync"
 	"sync/atomic"
@@ -233,7 +234,7 @@ func (c *CheckpointAdvancer) tryAdvance(ctx context.Context, length int,
 		defer c.checkpointsMu.Unlock()
 		c.checkpoints.Merge(spans.Valued{Key: kr, Value: u})
 	})
-	clampedRanges := utils.IntersectAll(ranges, utils.CloneSlice(c.taskRange))
+	clampedRanges := utils.IntersectAll(ranges, slices.Clone(c.taskRange))
 	for _, r := range clampedRanges {
 		workers.ApplyOnErrorGroup(eg, func() (e error) {
 			defer c.recordTimeCost("get regions in range")()

br/pkg/utils/key.go

@@ -143,13 +143,6 @@ func clampInOneRange(rng kv.KeyRange, clampIn kv.KeyRange) (kv.KeyRange, failedT
 	return rng, successClamp
 }
 
-// CloneSlice sallowly clones a slice.
-func CloneSlice[T any](s []T) []T {
-	r := make([]T, len(s))
-	copy(r, s)
-	return r
-}
-
 // IntersectAll returns the intersect of two set of segments.
 // OWNERSHIP INFORMATION:
 // For running faster, this function would MUTATE the input slice. (i.e. takes its ownership.)

br/pkg/utils/key_test.go

@@ -5,6 +5,7 @@ package utils
 import (
 	"encoding/hex"
 	"fmt"
+	"slices"
 	"testing"
 
 	"github.com/pingcap/tidb/pkg/kv"
@@ -162,7 +163,7 @@ func TestClampKeyRanges(t *testing.T) {
 	run := func(t *testing.T, c Case) {
 		require.ElementsMatch(
 			t,
-			IntersectAll(CloneSlice(c.ranges), CloneSlice(c.clampIn)),
+			IntersectAll(slices.Clone(c.ranges), slices.Clone(c.clampIn)),
 			c.result)
 		require.ElementsMatch(
 			t,