Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headless checkbox #683

Merged
merged 95 commits into from
Jun 18, 2024
Merged

Add headless checkbox #683

merged 95 commits into from
Jun 18, 2024

Conversation

TheMcnafaha
Copy link
Member

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5f9d1e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TheMcnafaha TheMcnafaha mentioned this pull request Apr 3, 2024
Closed
34 tasks
@shairez shairez mentioned this pull request Apr 3, 2024
Closed
37 tasks
@shairez shairez mentioned this pull request Apr 17, 2024
Closed
29 tasks
TheMcnafaha added 26 commits May 19, 2024 18:30
@TheMcnafaha
FEAT: fixed tailwind config bug
6c50beb
@TheMcnafaha
FEAT: working render of test
10af9af
@TheMcnafaha
FIX: added test files to tailwind config
e3e486d 
This makes sure headless components behave the same on playwright as
they do in dev mode.

If removed, the checkbox component test that makes sure the icons are
hidden will fail as the appropiate tailwind classes won't be added *in
playwright mode only*. Unbeknownst to me, the tailwind classes are added
in dev mode.
@TheMcnafaha
FEAT: added tests for single checkbox behavior
39aca37
@TheMcnafaha
FIX: better tailwind config
2638e11
@TheMcnafaha
FEAT: added test for default checkbox
6e1fcac
@TheMcnafaha
FEAT: test for checklist renders
3746b46
@TheMcnafaha
FEAT: better test driver
c68c49b
@TheMcnafaha
FEAT: better getCheckbox driver method
c61889c
@TheMcnafaha
FEAT: added tests to checklist
06f14b5
@TheMcnafaha
FEAT: buggy hellish halfworking checklist context JSX hack
848a395
@TheMcnafaha
FIX: removed bug that creates multiple sigs on checklist's context
efcc706
@TheMcnafaha
FEAT: refactored checklistContext to use a sig
433b338
@TheMcnafaha
FIX: removed circular muation
d8c3d29
@TheMcnafaha
FEAT: better context code structure, but still not good
40e9dec
@TheMcnafaha
FEAT: working tricheckbox icon
af8a4c7
@TheMcnafaha
FEAT: added checklist child-to-parent behavior
14eeb05
@TheMcnafaha
FEAT: split checkbox into 2 components to ease logic
f375639
@TheMcnafaha
FEAT: added test for aria-controls
3fdd48a
@TheMcnafaha
FEAT: added more tests for aria-controls
8ce69f6
@TheMcnafaha
FEAT: added functionality and tests for parent-child checklist behavior
571b8ff
@TheMcnafaha
FEAT: added final ids tests for aria-controls
6769747
@TheMcnafaha
FEAT: added first test for controlled checklist
83b490e
@TheMcnafaha
FIX: removed bug on checklist bool logic leading to wrong initial ari…
e599453 
…a-checked state
@TheMcnafaha
FEAT: added test for controlled checklist with all checked checkboxes
25b51aa
@TheMcnafaha
FEAT: added test for controlled checklist with all unchecked checkboxes
b83e329
@TheMcnafaha TheMcnafaha force-pushed the add-headless-checkbox branch from e43a3f2 to e6462e9 Compare May 19, 2024 22:53
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 26, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 5f9d1e4

@qwik-ui/headless

npm i https://pkg.pr.new/@qwik-ui/headless@683

templates

@thejackshelton
Copy link
Collaborator

For those reading this, we need the checkbox and checklist as a primitive in the dropdown menu. We are close to a beta state on this and so it is being merged to use in the other component.

@thejackshelton thejackshelton merged commit cf91aa5 into qwikifiers:main Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheMcnafaha @thejackshelton @JerryWu1234