Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove | fix double dark:hover:bg-... on MenuIcon (hamburger <svg>) #833

Closed
wants to merge 2 commits into from

Conversation

seanperez-xyz
Copy link

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

fixes double background in dark mode ( ?could be fixed by using the same color as the button ?)
may not apply to all, but typically when I do svg components I just spread the props in there and make the default inherit ( which I think is a tailwind preflight)

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • [?] I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Jun 8, 2024

⚠️ No Changeset found

Latest commit: 63a5932

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 8, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@maiieul
Copy link
Contributor

maiieul commented Jun 14, 2024

@seanperez-xyz good catch! Thanks for the PR! Can you just sign the cli pls 🙏 ?

@maiieul
Copy link
Contributor

maiieul commented Jun 29, 2024

I went ahead and fixed this with stroke-foreground in another PR. Thanks @seanperez-xyz for bringing this up! 🙏

@maiieul maiieul closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants