Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: nx 19.2.3 #841

Closed
wants to merge 1 commit into from
Closed

chore: nx 19.2.3 #841

wants to merge 1 commit into from

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Jun 13, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f0b47ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maiieul maiieul force-pushed the nx-19.2 branch 3 times, most recently from aa29d6c to a827576 Compare June 13, 2024 16:15
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@qwik-ui/headless (f0b47ad)

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@841

maiieul
maiieul commented Jun 13, 2024
View reviewed changes
.github/actions/setup/action.yml
@@ -41,4 +41,4 @@ runs:

- name: Install dependencies
shell: bash
run: pnpm install --frozen-lockfile
run: pnpm install --no-frozen-lockfile
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change that to upgrade to pnpm v9. Do we need to set it back to --frozen-lockfile in a follow up PR @shairez ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was the change needed on CI? can you please give more context?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was this frozen lockfile error:

image

@maiieul maiieul closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shairez shairez shairez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiieul @shairez