Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated notifications: fading-effect bug with long list of notifications #19

Closed
Leleat opened this issue Nov 3, 2022 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Leleat
Copy link
Contributor

Leleat commented Nov 3, 2022

image

@Leleat
Copy link
Contributor Author

Leleat commented Nov 4, 2022

It does appear to be related to the scrollbar. Changing the scrollbar's width to 0 will expand the fade effect. Adding this.list.get_vscroll_bar().width = 0 to notifications.js will result in this

image

Downside is there is no scrollbar visible at all... although I think it actually looks good.

Do you want me to open a PR with this? Or do you want to try to find a different/proper fix? Maybe you can do something in css since that's how you also enlarged the messages...

@qwreey qwreey added the bug Something isn't working label Nov 6, 2022
@qwreey qwreey self-assigned this Nov 6, 2022
@qwreey qwreey pinned this issue Nov 6, 2022
@qwreey
Copy link
Owner

qwreey commented Nov 11, 2022

I can't found that how to check when vscrollbar_visible of StScrollView will be change

// ... basic
list.vscroll.connect("hide")
: not work, show too

// Checking by height
list.last_child.connect("notify::height")
: not work

// Checking by property notify
list.connect("notify::vscrollbar_visible")
: not work

// Checking by child add/remove event
list.last_child.first_child.first_child.connect("actor-added",()=>{Main.testt})
: not work

And also, i can't found any useful information in https://gjs-docs.gnome.org/st10~1.0_api/st.scrollview
Did you know how to get event of 'vscrollbar_visible'?

@Leleat
Copy link
Contributor Author

Leleat commented Nov 11, 2022

I can't found that how to check when vscrollbar_visible of StScrollView will be change

Sorry, don't know either :/. Maybe someone on the extension matrix channel may know...

@Leleat
Copy link
Contributor Author

Leleat commented Nov 23, 2022

Hmm, this sounds like the cause/fix of this issue... ?

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2190/

qwreey added a commit that referenced this issue Apr 29, 2023
@qwreey
Copy link
Owner

qwreey commented Apr 29, 2023

image
image

This bug was fixed on dev branch. now it toggles overlay_scrollbars property automatically!

@qwreey qwreey closed this as completed Apr 29, 2023
@qwreey qwreey mentioned this issue May 2, 2023
@qwreey qwreey unpinned this issue May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants