Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap readr for data.table as creator of TSV #271

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jd4ds
Copy link

@jd4ds jd4ds commented Jun 14, 2022

This closes #270.

@krlmlr
Copy link
Member

krlmlr commented Jun 18, 2022

Thanks. I tweaked myself to ensure that CI/CD is run.

Should we perhaps consider offering both ways of creating the CSV files, and perhaps make the data.table way opt-in for now?

@krlmlr
Copy link
Member

krlmlr commented Jun 18, 2022

Something's not quite right yet with the tests, could you please take a look?

@jd4ds
Copy link
Author

jd4ds commented Jun 20, 2022

Ok I'll see if I understand whats going on.

Copy link
Contributor

aviator-app bot commented Apr 1, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@@ -61,23 +61,23 @@ db_append_table <- function(conn, name, value, warn_factor = TRUE, safe = TRUE,
sql <- paste0(
"LOAD DATA LOCAL INFILE ", dbQuoteString(conn, path), "\n",
"IGNORE\n",
"FIELDS TERMINATED BY ", dbQuoteString(conn, "\t"), "\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

Suggested change
"FIELDS TERMINATED BY ", dbQuoteString(conn, "\t"), "\n",
"FIELDS TERMINATED BY ", dbQuoteString(conn, "\\t"), "\n",

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db_append_table should not double escape already escaped quotes
3 participants