Apply suggestions from code review

Co-authored-by: Adam Foryś <adam.forys@gmail.com>
r-dbi · Dec 12, 2021 · 506ab86 · 506ab86
1 parent a217c9b
commit 506ab86
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/R/PqConnection.R b/R/PqConnection.R
@@ -318,7 +318,7 @@ postgresWaitForNotify <- function (conn, timeout = 1) {
 #'   [DBI::dbConnect()]
 #' @return A boolean, indicating if a transaction is ongoing.
 postgresIsTransacting <- function(conn) {
-  connection_is_transacting(conn)
+  connection_is_transacting(conn@ptr)
 }
 
 #' Determine database type for R vector.

diff --git a/tests/testthat/test-isTransacting.R b/tests/testthat/test-isTransacting.R
@@ -3,9 +3,9 @@ context("isTransacting")
 test_that("isTransacting detects transactions correctly", {
   skip_on_cran()
   db <- postgresDefault()
-  expect_fale(postgresIsTransacting(con))
+  expect_false(postgresIsTransacting(con))
   dbBegin(con)
   expect_true(postgresIsTransacting(con))
   dbCommit(con)
-  expect_fale(postgresIsTransacting(con))
+  expect_false(postgresIsTransacting(con))
 })