Skip to content

Commit

Permalink
Correct str_detect() translation (#384)
Browse files Browse the repository at this point in the history
Fixes #369
  • Loading branch information
jimmyg3g authored May 5, 2020
1 parent a258fd6 commit 35a80ad
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# bigrquery (development version)

* `str_detect()` now correctly translated to `REGEXP_CONTAINS`
(@jimmyg3g, #369).

* Error messages inlude hints for common problems (@deflaux, #353).

* `bq_perform_upload()` works once again (#361). It seems like the generated
Expand Down
2 changes: 1 addition & 1 deletion R/dplyr.R
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ sql_translate_env.BigQueryConnection <- function(x) {
paste0 = sql_prefix("CONCAT"),

# stringr equivalents
str_detect = sql_prefix("REGEXP_MATCH", 2),
str_detect = sql_prefix("REGEXP_CONTAINS", 2),
str_extract = sql_prefix("REGEXP_EXTRACT", 2),
str_replace = sql_prefix("REGEXP_REPLACE", 3),

Expand Down

0 comments on commit 35a80ad

Please sign in to comment.