Parameter support for DBI dbGetQuery

NEWS.md

@@ -4,6 +4,8 @@
 
 * Improve int64 support when reading BigQuery tables with dplyr syntax. `collect()` now utilizes `bigint` parameter in `DBI::dbConnect()` object. Set `bigint` in connection object to `"integer64"` or `"character"` to avoid integer coercion and overflow issues (@zoews, #439, #437).
 
+* `DBI:dbGetQuery()` - now can take params attribute which will work with parameterised queries (@byapparov, #443)
+
 # bigrquery 1.3.2
 
 * BigQuery `BYTES` and `GEOGRAPHY` column types are now supported via

R/bq-perform.R

@@ -263,7 +263,7 @@ bq_perform_query <- function(query, billing,
     priority = unbox(priority)
   )
 
-  if (!is.null(parameters)) {
+  if (length(parameters) > 0) {
     parameters <- as_bq_params(parameters)
     query$queryParameters <- as_json(parameters)
   }

R/dbi-result.R

@@ -1,11 +1,13 @@
 #' @include dbi-connection.R
 NULL
 
-BigQueryResult <- function(conn, sql, ...) {
+BigQueryResult <- function(conn, sql, params = NULL, ...) {
+
   if (is.null(conn@dataset)) {
     job <- bq_perform_query(sql,
       billing = conn@billing,
       quiet = conn@quiet,
+      parameters = params,
       ...
     )
   } else {
@@ -14,6 +16,7 @@ BigQueryResult <- function(conn, sql, ...) {
       billing = conn@billing,
       default_dataset = ds,
       quiet = conn@quiet,
+      parameters = params,
       ...
     )
   }

tests/testthat/test-dbi-result.R

@@ -10,6 +10,19 @@ test_that("can retrieve full query results", {
   expect_equal(df, tibble(count = 32L))
 })
 
+test_that("can retrieve parameterized query results", {
+  con <- DBI::dbConnect(
+    bigquery(),
+    project = bq_test_project(),
+    dataset = "basedata",
+    bigint = "integer"
+  )
+
+  df <- DBI::dbGetQuery(con, "SELECT @value AS value", params = (value = 100))
+  expect_equal(df, tibble(value = 100))
+})
+
+
 test_that("can retrieve without dataset", {
   con <- DBI::dbConnect(
     bigquery(),