New format_dataset() and format_table() #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #' @family identifier functions | ||
| #' @export | ||
| parse_dataset <- function(dataset, project_id = NULL) { | ||
| assert_that(is.string(dataset), is.null(project_id) || is.string(project_id)) |
There was a problem hiding this comment.
small nit: i think this is easier to read when each assertion is on its own line, eg
assert_that(is.string(dataset),
is_null(project_id) || is.string(project_id))
|
LGTM to me modulo comments above. totally fine with moving these all out of |
|
Addressed your comments and added tests. |
added 3 commits
January 29, 2016 09:31
for painless merging of NEWS.md
|
LGTM, happy to resolve the other bits separately |
craigcitro
added a commit
that referenced
this pull request
Jan 29, 2016
New format_dataset() and format_table()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as complement to parse_*().
@craigcitro: Okay to create a new file for these functions and move them out of utils.R? If not, I'll revert that particular change before adding tests.