-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Found detritus in the temp directory" #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! Just some comments on the wording, but take them with a grain of salt.
Thanks @llrs Co-authored-by: Lluís Revilla <llrs@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a really good recipe and also our first "guest" recipe. Thanks for the PR!
I suggested some small changes regarding the "CRAN compatibility" of recipes. @jasdumas and I will discuss adding a note about that in the template. We decided at the start of the project, that all recipes should also follow all CRAN rules.
@aitap, can you maybe add the exact CRAN/R CMD check
NOTE as well? I suppose the best way to do that is in a callout note similar to the overall checktime recipe.
Co-authored-by: Beni Altmann <100207206+Baltmann01@users.noreply.github.com>
Added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for all the detail and links in this recipe 🍽️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@aitap You are clear to merge in the PR 🎉 |
Am I understanding you correctly that you would like me to press the merge button? Looks like I don't have the write access to do that. |
Ah, we'll look into this. I merged the PR now! Thanks |
This is the recipe from #59 reworded according to the template. Thank you very much @hturner and @jasdumas for the comments.