Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Found detritus in the temp directory" #69

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

aitap
Copy link
Contributor

@aitap aitap commented Nov 15, 2024

This is the recipe from #59 reworded according to the template. Thank you very much @hturner and @jasdumas for the comments.

Copy link
Member

@llrs llrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Just some comments on the wording, but take them with a grain of salt.

code_issues.qmd Outdated Show resolved Hide resolved
code_issues.qmd Outdated Show resolved Hide resolved
Thanks @llrs

Co-authored-by: Lluís Revilla <llrs@users.noreply.github.com>
Copy link
Contributor

@Baltmann01 Baltmann01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a really good recipe and also our first "guest" recipe. Thanks for the PR!

I suggested some small changes regarding the "CRAN compatibility" of recipes. @jasdumas and I will discuss adding a note about that in the template. We decided at the start of the project, that all recipes should also follow all CRAN rules.

@aitap, can you maybe add the exact CRAN/R CMD check NOTE as well? I suppose the best way to do that is in a callout note similar to the overall checktime recipe.

code_issues.qmd Outdated Show resolved Hide resolved
code_issues.qmd Outdated Show resolved Hide resolved
code_issues.qmd Outdated Show resolved Hide resolved
code_issues.qmd Outdated Show resolved Hide resolved
aitap and others added 2 commits November 20, 2024 10:41
Co-authored-by: Beni Altmann <100207206+Baltmann01@users.noreply.github.com>
@aitap
Copy link
Contributor Author

aitap commented Nov 20, 2024

Added the NOTE, thank you for the improvements!

Copy link
Contributor

@jasdumas jasdumas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for all the detail and links in this recipe 🍽️

Copy link
Contributor

@Baltmann01 Baltmann01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jasdumas
Copy link
Contributor

@aitap You are clear to merge in the PR 🎉

@aitap
Copy link
Contributor Author

aitap commented Nov 23, 2024

Am I understanding you correctly that you would like me to press the merge button? Looks like I don't have the write access to do that.

@Baltmann01
Copy link
Contributor

Ah, we'll look into this. I merged the PR now! Thanks

@Baltmann01 Baltmann01 merged commit e5e4b54 into r-devel:main Nov 25, 2024
@aitap aitap deleted the detritus branch November 27, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants