Skip to content

Commit

Permalink
Also NOTE missing Rd aliases for docType 'package'.
Browse files Browse the repository at this point in the history
git-svn-id: https://svn.r-project.org/R/trunk@84746 00db46b3-68df-0310-9c12-caf00c1e9a41
  • Loading branch information
hornik committed Jul 24, 2023
1 parent ed527e3 commit f7fa5fb
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
8 changes: 1 addition & 7 deletions src/library/tools/R/QC.R
Original file line number Diff line number Diff line change
Expand Up @@ -8939,13 +8939,7 @@ function(package, dir, lib.loc = NULL)
out$files_with_duplicated_aliases <-
files_with_duplicated_aliases

## <FIXME>
## This currently ignores package overview files:
## thousands of packages lack the required pkgname-package alias,
## which we might thus want to handle separately, also that
## some packages provide multiple files with docType "package" ...
## </FIXME>
out$files_without_aliases <- files[nAliases == 0L & doctypes != "package"]
out$files_without_aliases <- files[nAliases == 0L]

out
}
Expand Down
11 changes: 10 additions & 1 deletion src/library/tools/R/check.R
Original file line number Diff line number Diff line change
Expand Up @@ -2312,7 +2312,16 @@ add_dummies <- function(dir, Log)
sprintf("tools:::.check_Rd_metadata(dir = \"%s\")\n", pkgdir))
out <- R_runR0(Rcmd, R_opts2, "R_DEFAULT_PACKAGES=NULL")
if (length(out)) {
warningLog(Log)
## <FIXME>
## We should really use R() instead if R_runR0() to get
## the computed check results object itself.
## Change eventually ...
## </FIXME>
tag <- out[!startsWith(out, " ")]
if(any(grepl("duplicated", tag, fixed = TRUE)))
warningLog(Log)
else
noteLog(Log)
printLog0(Log, paste(c(out, ""), collapse = "\n"))
} else resultLog(Log, "OK")
}
Expand Down

0 comments on commit f7fa5fb

Please sign in to comment.