define OBJSXP #128
Closed
define OBJSXP #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> dput(object())
object()
> dput(object('foo'))
object()
This will require a more careful approach; the S4 bit can be set on non-S4SXP types too.
t-kalinowski
force-pushed
the
rename-s4sxp
branch
from
31803a8
to
2657ca3
Compare
2 tasks
|
This is merged into master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OBJSXPas an alias forS4SXPdput()andprint()do something sensible on anOBJSXPwhen the S4 bit is not settypeof()returns"object"on anOBJSXPif the S4 bit is unset.Internal(inspect(x))printsOBJSXPinstead ofS4SXPif the S4 bit is unsetAlso, this PR adds aThe code for the constructor is commented out, since it's not clear if this is a good thing to add to base R presently.base::object()constructor that returns anOBJSXPwith the S4 bit unset. This is mainly for testing and experimentation purposes, and I'm not currently thinking it should be added to base R.