Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pdf epub options #70

Merged
merged 6 commits into from
Sep 26, 2022
Merged

add pdf epub options #70

merged 6 commits into from
Sep 26, 2022

Conversation

SaranjeetKaur
Copy link
Collaborator

No description provided.

@SaranjeetKaur SaranjeetKaur added the gsod-2022 Google Season of Docs related task label Sep 16, 2022
@hturner
Copy link
Member

hturner commented Sep 26, 2022

I made a few changes:

  • A local copy of the image of the edit icon was required to compile the PDF version. I also added some alternative text for the image: all images should have this for accessibility. This comes out as a caption in the PDF.
  • Updated the GitHub Action in .github/deplot_bookdown.yml so the PDF and EPUB get rendered - otherwise there will be no PDF or EPUB to download!
  • Removed bs4_book output format - this would be an alternative to the gitbook HTML version we are currently using. It may have some advantages, but this is a separate issue from adding PDF/EPUB downloads and would require to update screenshots etc if we wanted to move to that. So we should stick to gitbook here.
  • Updated the README with notes on handling of images and previewing PDF/EPUB

I've tested the PDF and EPUB downloads locally (you need to render them separately as noted in the README).

@SaranjeetKaur Can you review my changes then merge this in so we can test the GitHub Action?

README.md Outdated Show resolved Hide resolved
@SaranjeetKaur
Copy link
Collaborator Author

SaranjeetKaur commented Sep 26, 2022

Updated a minor typo. The changes look good to me. I'll merge this PR now. Thank you!

@SaranjeetKaur SaranjeetKaur merged commit 6cabeca into master Sep 26, 2022
@hturner hturner deleted the pdf-download branch September 28, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsod-2022 Google Season of Docs related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants