Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to exclude Suggests in setup-r-dependencies@v1 #409

Closed
MLopez-Ibanez opened this issue Oct 13, 2021 · 3 comments
Closed

Ability to exclude Suggests in setup-r-dependencies@v1 #409

MLopez-Ibanez opened this issue Oct 13, 2021 · 3 comments
Labels
feature a feature request or enhancement

Comments

@MLopez-Ibanez
Copy link

Describe the bug
Rmpi is listed in "Suggests" in my package, but fails to build in macos.
I'd like to exclude Rmpi from the dependencies installed by setup-dependencies-r@v1.

To Reproduce

https://github.com/MLopez-Ibanez/irace/runs/3888657260

Expected behavior

An action option allowing to either only install "Depends", "Imports" and "LinkingTo" (the default in remotes::install_deps() or to explicitly exclude packages.

Something like:

      - uses: r-lib/actions/setup-r-dependencies@v1
        if: runner.os == 'Linux'
        with:
          extra-packages: |
             devtools
             rcmdcheck
      - uses: r-lib/actions/setup-r-dependencies@v1
        if: runner.os != 'Linux' 
        with:
          extra-packages: |
             devtools
             rcmdcheck
         exclude: Rmpi
@MLopez-Ibanez MLopez-Ibanez added the bug an unexpected problem or unintended behavior label Oct 13, 2021
@jimhester jimhester added feature a feature request or enhancement and removed bug an unexpected problem or unintended behavior labels Oct 14, 2021
@jimhester
Copy link
Member

This is being tracked by r-lib/pak#296 and r-lib/pak#290. Once pak has a way to ignore a dependency we can then possibly add something like this to the workflows.

Until then you may need to use remotes to do the installation on macOS.

@gaborcsardi
Copy link
Member

In v2 setup-r-dependencies now has a dependencies parameter and if you set it to "hard" then the suggested packages won't be installed.

The pak issues referenced above will provide a better solution for failing optional dependencies in general, they are coming soon.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants