Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandoc install failure not shown as failure #515

Closed
hadley opened this issue Mar 1, 2022 · 2 comments · Fixed by #528
Closed

Pandoc install failure not shown as failure #515

hadley opened this issue Mar 1, 2022 · 2 comments · Fixed by #528
Labels
bug an unexpected problem or unintended behavior

Comments

@hadley
Copy link
Member

hadley commented Mar 1, 2022

In https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true, I see:

Mar  1 13:58:55  installer[[9](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:9)09] <Critical>: Error parsing distribution script from data
9
installer: Error - the package path specified was invalid: '/Users/runner/work/_temp/pandoc-2.14.2-macOS.pkg'.
[10](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:10)
(node:900) UnhandledPromiseRejectionWarning: Error: The process 'sudo' failed with exit code 1
[11](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:11)
    at ExecState._setResult (/Users/runner/work/_actions/r-lib/actions/v2/setup-pandoc/node_modules/@actions/exec/lib/toolrunner.js:548:25)
[12](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:12)
    at ExecState.CheckComplete (/Users/runner/work/_actions/r-lib/actions/v2/setup-pandoc/node_modules/@actions/exec/lib/toolrunner.js:531:18)
[13](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:13)
    at ChildProcess.<anonymous> (/Users/runner/work/_actions/r-lib/actions/v2/setup-pandoc/node_modules/@actions/exec/lib/toolrunner.js:431:27)
[14](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:14)
    at ChildProcess.emit (events.js:210:5)
[15](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:15)
    at maybeClose (internal/child_process.js:1021:[16](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:16))
16
    at Socket.<anonymous> (internal/child_process.js:430:11)
[17](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:17)
    at Socket.emit (events.js:210:5)
[18](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:18)
    at Pipe.<anonymous> (net.js:659:12)
[19](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:19)
(node:900) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
[20](https://github.com/tidyverse/haven/runs/5376303481?check_suite_focus=true#step:3:20)
(node:900) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

But the step itself doesn't show as a failure.

@gaborcsardi gaborcsardi added the bug an unexpected problem or unintended behavior label Mar 1, 2022
@gaborcsardi
Copy link
Member

This is not in v2 yet. Soon.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants