Fix unhandled promise rejections #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the installation fails, the exception is not propagated to the try-catch in `run()`, but dropped instead. We resolve this by returning their promises. Resolves #515
Makes use of definite-assignment analysis.
Codecov Report
@@ Coverage Diff @@
## v2-branch #528 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 2 2
Lines 10 10
===========================================
Hits 10 10 Continue to review full report at Codecov.
|
Falls back to the error itself, if the catch param does not have a message. Before, accessing `err.message` would print `undefined` because strings were thrown.
nikeee
added a commit
to nikeee/setup-pandoc
that referenced
this pull request
Mar 12, 2022
Some fixes were published upstream: r-lib/actions#528
When the network is slow or down, it is good to see what is going on.
|
Thanks! This action uses node 12, still, so made some small updates and regenerated the JS with an older typescript. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While forking and refactoring this action, I discovered some issues. This is a backport to upstream of these fixes.
In case the installation fails, the exception is not propagated to the try-catch in
run(), but dropped instead.We resolve this by returning their promises.
Resolves #515