Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error from actions/upload-artifact #593

Closed
t-kalinowski opened this issue Aug 3, 2022 · 3 comments · Fixed by #595
Closed

Error from actions/upload-artifact #593

t-kalinowski opened this issue Aug 3, 2022 · 3 comments · Fixed by #595
Labels
bug an unexpected problem or unintended behavior

Comments

@t-kalinowski
Copy link
Member

t-kalinowski commented Aug 3, 2022 •
edited
Loading

Describe the bug
in r-lib/actions/check-r-package@v2, on a failed check, the actions/upload-artifact@main composite step fails with error:

Error: Input required and not supplied: path

To Reproduce
Example

Expected behavior
Successfully uploaded test artifacts

Additional context
I don't know if this is related, but perhaps worth mentioning: the autogenerated names for artifacts are not unique. This is the case for reticulate (and tensorflow and other packages that test across versions of some external dependency).
@t-kalinowski t-kalinowski added the bug an unexpected problem or unintended behavior label Aug 3, 2022
@riccardoporreca
Copy link
Contributor

@t-kalinowski, I probably introduced the problem while fixing a different issue in #560, I can probably have a PR fixing the fix today

riccardoporreca added a commit to riccardoporreca/actions that referenced this issue Aug 4, 2022
@riccardoporreca
Introduce artificial test failure to reproduce upload artifact issue r…
0ef75f0 
…-lib#593
@riccardoporreca
Copy link
Contributor

See the commit above reproducing the issue with a minimal change to .github/workflows/check-standard.yaml in the r-lib/actions repo, in the following situation:

The artifact upload fails since rcmdcheck failures prevent the command setting the output (introduced in #560) from being executed.

riccardoporreca added a commit to riccardoporreca/actions that referenced this issue Aug 4, 2022
@riccardoporreca
Fix resolving the exposed check-dir for the artifact upload
2dbc0b3 
* Given the R-expression-nature of `inputs.check-dir`, we still rely on a step output defined from within R but just uses the expression.
* We need to define the output before running the checks to fix r-lib#593 (introduced by r-lib#560) in case of check failures.
riccardoporreca added a commit to riccardoporreca/actions that referenced this issue Aug 4, 2022
@riccardoporreca
Test the fix for r-lib#593 from the corresponding branch
01851b2
@riccardoporreca riccardoporreca mentioned this issue Aug 4, 2022
Merged
@gaborcsardi gaborcsardi mentioned this issue Aug 5, 2022
Closed
riccardoporreca added a commit to riccardoporreca/actions that referenced this issue Sep 5, 2022
@riccardoporreca
Introduce artificial test failure to reproduce upload artifact issue r…
c5fb812 
…-lib#593
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix resolving the exposed check-dir for the artifact upload riccardoporreca/actions
2 participants
@t-kalinowski @riccardoporreca