fix: commit all styled files (styler example) #693
Conversation
Codecov Report
@@ Coverage Diff @@
## v2-branch #693 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 2 2
Lines 10 10
===========================================
Hits 10 10 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
this should fix #617 |
examples/style.yaml
Outdated
| shell: Rscript {0} | ||
|
|
||
| - name: Commit and push changes | ||
| run: | | ||
| git config --local user.name "$GITHUB_ACTOR" | ||
| git config --local user.email "$GITHUB_ACTOR@users.noreply.github.com" | ||
| git add R/\* | ||
| git add \*.[rR] \*.[qrR]md \*.[rR]markdown \*.[rR]nw \*.[rR]profile |
There was a problem hiding this comment.
This throws an error, if one of those extensions is not available in the repo (which is quite likely). 😫
There was a problem hiding this comment.
git add --ignore-errors throws the same error on GHA.
|
Are you still planning on finishing this PR? |
|
@gaborcsardi Thanks for the reminder! This is finished now from my point of view. |
|
Thanks! |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
I noticed that not all styled files get committed to the repo in the styler example workflow. Example: 2 styled files vs 1 committed.
That made me think that we should style all supported files (currently qmd and Rprofile are missing) and trigger the workflow also on changes to (local) Rprofile.
cc @arisp99