Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file names as workflow names #888

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

gaborcsardi
Copy link
Member

To make it easier to match workflow runs to workflow files. usethis::use_github_action() renames the files starting with check- to R-CMD-check.yaml by default, so we anticipate that here, except for the no-suggests workflow.

To make it easier to match workflow runs to workflow files.
`usethis::use_github_action()` renames the files starting
with `check-` to `R-CMD-check.yaml` by default, so we
anticipate that here, except for the no-suggests workflow.
@gaborcsardi gaborcsardi requested review from hadley and jeroen July 31, 2024 08:02
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.33%. Comparing base (cdb0370) to head (668b0b3).

Additional details and impacted files
@@            Coverage Diff             @@
##           v2-branch     #888   +/-   ##
==========================================
  Coverage      83.33%   83.33%           
==========================================
  Files              3        3           
  Lines             12       12           
==========================================
  Hits              10       10           
  Misses             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Jul 31, 2024

Deploying actions with  Cloudflare Pages  Cloudflare Pages

Latest commit: 668b0b3
Status: ✅  Deploy successful!
Preview URL: https://5f4c24c9.actions-61h.pages.dev
Branch Preview URL: https://example-workflow-names.actions-61h.pages.dev

View logs

hadley
hadley previously approved these changes Jul 31, 2024
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@gaborcsardi gaborcsardi merged commit 65c3db3 into v2-branch Aug 2, 2024
31 checks passed
@gaborcsardi gaborcsardi deleted the example-workflow-names branch August 2, 2024 09:10
@krlmlr
Copy link
Member

krlmlr commented Aug 7, 2024

This now leads to the .yaml extension being shown in the badge. See, e.g., https://github.com/r-lib/usethis#readme 👍

image

Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants