Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving package cache on Windows & older R #944

Merged
merged 8 commits into from
Nov 9, 2024

Conversation

gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Nov 9, 2024

Closes #940.

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (9073210) to head (ee73b7e).
Report is 1 commits behind head on v2-branch.

Additional details and impacted files
@@            Coverage Diff             @@
##           v2-branch     #944   +/-   ##
==========================================
  Coverage      84.61%   84.61%           
==========================================
  Files              3        3           
  Lines             13       13           
==========================================
  Hits              11       11           
  Misses             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Temporarily for now.
@gaborcsardi gaborcsardi force-pushed the fix/old-r-windows-save-cache branch from a9ab078 to 260c92a Compare November 9, 2024 09:57
@gaborcsardi gaborcsardi requested a review from jeroen November 9, 2024 10:44
@jeroen
Copy link
Member

jeroen commented Nov 9, 2024

Awesome thanks!

@gaborcsardi gaborcsardi merged commit e9f20ef into v2-branch Nov 9, 2024
30 checks passed
@gaborcsardi
Copy link
Member Author

@jeroen: Thank you!

Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving the cache fails on Windows, on older R
2 participants