Skip to content

Commit

Permalink
Drop gcc 4.8 support (#359)
Browse files Browse the repository at this point in the history
* Drop gcc 4.8 testing

* NEWS bullet
  • Loading branch information
DavisVaughan authored Jul 25, 2024
1 parent 6a16f15 commit 152cb14
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 19 deletions.
19 changes: 0 additions & 19 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ jobs:
- {os: ubuntu-20.04, r: 'devel', http-user-agent: 'release'}
- {os: ubuntu-20.04, r: 'release'}
- {os: ubuntu-20.04, r: 'release', custom: 'no-cpp11test'}
- {os: ubuntu-20.04, r: 'release', custom: 'gcc 4.8'}
- {os: ubuntu-20.04, r: 'oldrel-1'}
- {os: ubuntu-20.04, r: 'oldrel-2'}
- {os: ubuntu-20.04, r: 'oldrel-3'}
Expand All @@ -57,24 +56,6 @@ jobs:
http-user-agent: ${{ matrix.config.http-user-agent }}
use-public-rspm: true

- name : Install compiler version
# We check on this old compiler specifically to support CentOS 7,
# which uses this gcc version. RStudio products support CentOS 7 through
# June 2024.
# https://github.com/r-lib/cpp11/pull/78
# https://www.rstudio.com/about/platform-support/
# Ubuntu 20.04 technically dropped support for gcc 4.8, so we have to
# add old archives back in manually to install it
# https://github.com/r-lib/cpp11/pull/279
if: matrix.config.custom == 'gcc 4.8'
run: |
echo "deb http://dk.archive.ubuntu.com/ubuntu/ xenial main" | sudo tee -a /etc/apt/sources.list
echo "deb http://dk.archive.ubuntu.com/ubuntu/ xenial universe" | sudo tee -a /etc/apt/sources.list
sudo apt update
sudo apt-get install -y g++-4.8
mkdir ~/.R/
echo $'CXX1X=g++-4.8\nCXX11=g++-4.8\nCC=gcc-4.8 -std=c99\nCXX=g++-4.8 -std=gnu++11' >> ~/.R/Makevars
- name: Install macOS system dependencies
if: runner.os == 'macOS'
run: brew install --cask xquartz
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# cpp11 (development version)

* Dropped support for gcc 4.8, mainly an issue for extremely old CentOS 7
systems which used that as their default compiler. As of June 2024, CentOS 7
is past its Vendor end of support date and therefore also out of scope for
Posit at this time (#359).

# cpp11 0.4.7

* Internal changes requested by CRAN to fix invalid format string tokens
Expand Down

0 comments on commit 152cb14

Please sign in to comment.