Skip to content

There should be a way to opt out of unwind_protect for a block of code. #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jimhester opened this issue Jan 5, 2021 · 0 comments · Fixed by #207
Closed

There should be a way to opt out of unwind_protect for a block of code. #141

jimhester opened this issue Jan 5, 2021 · 0 comments · Fixed by #207
Assignees
@sbearrows
Labels
feature a feature request or enhancement

Comments

@jimhester
Copy link
Member

jimhester commented Jan 5, 2021 •
edited
Loading

e.g. if you have a loop and want to put the protection outside around it rather than on each call.

Perhaps unwind_protect() should set a global flag, then we know that we don't need to unwind protect again?
@jimhester jimhester added the feature a feature request or enhancement label Jan 11, 2021
@jimhester jimhester assigned jimhester and sbearrows and unassigned jimhester Jul 7, 2021
jimhester added a commit that referenced this issue Jul 19, 2021
@jimhester
Support more efficient nesting of unwind_protect
40ec0a7 
The internal protection can be skipped if we are already in an
unwind_protect call.

Fixes #141
@jimhester jimhester mentioned this issue Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbearrows sbearrows

Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support more efficient nesting of unwind_protect r-lib/cpp11
2 participants
@jimhester @sbearrows