Skip to content

Add r_bool wrapper for Rboolean #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2020
Merged

Add r_bool wrapper for Rboolean #105

merged 4 commits into from
Sep 23, 2020

Conversation

bkietz
Copy link
Collaborator

@bkietz bkietz commented Sep 22, 2020

fixes #56

@bkietz bkietz requested a review from jimhester September 22, 2020 19:11
@bkietz
Copy link
Collaborator Author

bkietz commented Sep 22, 2020

@jimhester not sure why 2d34af9 was necessary, we don't see that error for the equivalent checks with r_string

@jimhester
Copy link
Member

Hmm, interesting, I am not sure why it would be needed either.

@jimhester
Copy link
Member

Otherwise I think this looks good, thank you for working on it!

@jimhester jimhester merged commit cdfeb88 into r-lib:master Sep 23, 2020
@jimhester jimhester deleted the r_bool branch September 23, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimhester jimhester Awaiting requested review from jimhester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

writable::logicals::proxy = bool
2 participants
@bkietz @jimhester