Skip to content

Conversation

@bkietz
Copy link
Collaborator

@bkietz bkietz commented Sep 22, 2020

fixes #56

@bkietz bkietz requested a review from jimhester September 22, 2020 19:11
@bkietz
Copy link
Collaborator Author

bkietz commented Sep 22, 2020

@jimhester not sure why 2d34af9 was necessary, we don't see that error for the equivalent checks with r_string

@jimhester
Copy link
Member

Hmm, interesting, I am not sure why it would be needed either.

@jimhester
Copy link
Member

Otherwise I think this looks good, thank you for working on it!

@jimhester jimhester merged commit cdfeb88 into r-lib:master Sep 23, 2020
@jimhester jimhester deleted the r_bool branch September 23, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

writable::logicals::proxy = bool

2 participants