Skip to content

rework is_na() #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 54 commits into from
Closed

rework is_na() #318

wants to merge 54 commits into from

Conversation

@romainfrancois
Copy link
Collaborator

@romainfrancois romainfrancois commented May 17, 2023

No description provided.

@romainfrancois romainfrancois changed the title include integers.hpp before doubles.hpp rework is_na() May 23, 2023
@romainfrancois
sexp& operator=(sexp&& rhs)
6abb94a
@romainfrancois
avoid hoops
a2b0565
@romainfrancois
both versions
ff20930
@romainfrancois
is_na()
9909967
@romainfrancois
cpp11::integers na4 = cpp11::as_cpp<cpp11::integers>(na);
3947b26
@romainfrancois
expect_true(na3.size() == 1);
9a9a2c2
@romainfrancois
expect_true(ISNA(na5[0]));
cb25d63
@romainfrancois
expect_true(el == NA_INTEGER);
ba11c0d
@romainfrancois
expect_true(ISNA(na6[0]));
2e7e8fe
@romainfrancois
cpp11::sexp na(Rf_ScalarReal(NA_INTEGER));
94cf731
@romainfrancois
cpp11::sexp na(Rf_ScalarInteger(NA_INTEGER));
0d4b92c
@romainfrancois
...
8c47148
@romainfrancois
typeof
b671935
@romainfrancois
-
dc9d601
@romainfrancois
order of preserve/release
5eade3e
@romainfrancois
...
7abccea
@romainfrancois
cpp11::integers na3(Rf_ScalarInteger(NA_INTEGER));
7082f36
@romainfrancois
move as_doubles to test file ???
c6a14ab
@romainfrancois
+++
1bb6e3e
@romainfrancois
Revert "avoid need for R_NilValue checks in protect code (#285)"
8b7f075 
This reverts commit dae1b6a.
@romainfrancois
as_integers()
b59982f
@romainfrancois
...
b614853
@romainfrancois
-as_cpp
b67c145
@romainfrancois
conversion ops back
1373226
@romainfrancois
SEXP as_doubles(SEXP x)
9b0a954
@romainfrancois romainfrancois mentioned this pull request May 24, 2023
Merged
@romainfrancois
Copy link
Collaborator Author

romainfrancois commented May 25, 2023

superseded by #319

@romainfrancois romainfrancois deleted the include_order_integers_doubles branch May 25, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romainfrancois