Require R >=3.5.0 and remove release_all()
#332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tied to #331, where we switch from a global preserve list to 1 preserve list per compilation unit.
release_all()
was intended to support experts that wanted to manually release cpp11 protected objects on R < 3.5.0, but it no longer is applicable for a few reasons:.Call()
boundary)No one was using
release_all()
as far as we can tell.I've also bumped the minimum R version to >=3.5.0, so we no longer need code that supports the "old times" before we had access to
R_UnwindProtect()
. To this end, I've removedCPP11_USE_PRESERVE_OBJECT
as well.I've kept some details in the internals vignette, because I think the discussion of the alternative approaches is still useful for historical context.