Skip to content

Vendoring path #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Vendoring path #340

wants to merge 6 commits into from

Conversation

pachadotdev
Copy link
Contributor

As @krlmlr suggested, it might be better to vendor to src/vendor instead of inst

This PR implements that and also a better handling and messages about Makevars

The only error I can't see why it happens is

══ Results ══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 6.8 s

── Failed tests ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error (test-vendor.R:13:5): cpp_vendor: errors if cpp11 is already vendored
Error: cpp11 is not installed
Backtrace:
    ▆
 1. └─cpp11::cpp_vendor(pkg_path(pkg)) at test-vendor.R:13:5

Error (test-vendor.R:25:5): cpp_vendor: vendors cpp11
Error: cpp11 is not installed
Backtrace:
    ▆
 1. └─cpp11::cpp_vendor(pkg_path(pkg)) at test-vendor.R:25:5

[ FAIL 2 | WARN 0 | SKIP 0 | PASS 107 ]

@pachadotdev pachadotdev closed this Nov 9, 2023
@pachadotdev pachadotdev deleted the vendoring_path branch November 9, 2023 01:40
@pachadotdev pachadotdev mentioned this pull request Nov 9, 2023
@krlmlr
Copy link
Member

krlmlr commented Nov 9, 2023

FWIW, you can update a PR by pushing or force-pushing to the same branch.

@pachadotdev
Copy link
Contributor Author

pachadotdev commented Nov 9, 2023 via email

@pachadotdev pachadotdev mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants