Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation warnings on Niagara clusters #399

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

pachadotdev
Copy link
Contributor

@pachadotdev pachadotdev commented Sep 5, 2024

Hi Davis

I hope you are doing well.

I am using cpp11 with vendoring to run my codes in the Niagara clusters. When I run my codes there, I get these warnings

── R CMD INSTALL ───────────────────────────────────────────────────────────────
─  installing *source* package ‘blazebenchmark’ ... (386ms)
   ** using staged installation
   ** libs
   g++ -std=gnu++14 -I"/scinet/niagara/software/2019b/opt/gcc-8.3.0/r/4.2.2-batteries-included/lib64/R/include" -DNDEBUG   -I/usr/local/include   -DARMA_OPENMP_THREADS=40 -I../inst/include -fpic  -O2 -ftree-vectorize -march=native  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c 01_own_functions.cpp -o 

   ../inst/include/cpp11/r_vector.hpp:425:2: warning: extra ‘;’ [-Wpedantic]
   ../inst/include/cpp11/r_vector.hpp:451:2: warning: extra ‘;’ [-Wpedantic]
   ../inst/include/cpp11/list.hpp:57:2: warning: extra ‘;’ [-Wpedantic]
   ../inst/include/cpp11/doubles.hpp:53:2: warning: extra ‘;’ [-Wpedantic]
   ../inst/include/cpp11/integers.hpp:54:2: warning: extra ‘;’ [-Wpedantic]
   ../inst/include/cpp11/logicals.hpp:53:2: warning: extra ‘;’ [-Wpedantic]
   ../inst/include/cpp11/raws.hpp:61:2: warning: extra ‘;’ [-Wpedantic]
   ../inst/include/cpp11/strings.hpp:54:2: warning: extra ‘;’ [-Wpedantic]

This PR solves that and it works exactly the same with with a cleaner log.

Best,

@DavisVaughan DavisVaughan merged commit dc93fb8 into r-lib:main Sep 5, 2024
16 checks passed
@DavisVaughan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants