-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it possible to add an author with a comment including e.g. an ORCID #69
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 100% 98.77% -1.23%
==========================================
Files 18 18
Lines 1131 1065 -66
==========================================
- Hits 1131 1052 -79
- Misses 0 13 +13
Continue to review full report at Codecov.
|
I can't reproduce the Travis failure locally 🤔 |
Oh I know why it fails! One of the tests I've added checks that one can add an ORCID. I check for the string resulting from I'll add some skipping. |
Thanks! |
…CID (r-lib#69) * make it possible to add an author with a comment including an ORCID * fix assertion * fix on failure line * fix assertion * add test for NA assertion * skip test on older R versions * add test of failure * typo!
cf #65 (in preparation for the PR I intend to do for #63 )
One thing I wasn't sure about is whether you can add anything to the comment field, or whether there's a limited number of named strings that can go in there. I wasn't able to find that in "Writing R extensions" (where the ORCID support isn't documented yet anyway).