New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement build_vignettes() from first principles #2290

Closed

hadley opened this issue Oct 30, 2020 · 1 comment

Labels

feature vignettes 📜

Member

hadley commented Oct 30, 2020

To remove GPL code so we can relicense

hadley mentioned this issue

Relicensing devtools (1/2) #2292

Closed

50 tasks

hadley mentioned this issue

Relicensing devtools (wrap up) #2326

Closed

6 tasks

hadley added feature vignettes 📜 labels

Member Author

hadley commented Feb 18, 2021

Commit that copied the code: c607d0f

The problem is actually copy_vignettes() and find_vignette_extras().

copy_vignettes() comes from https://github.com/wch/r-source/blob/66fa35c1b7fe8993c1f4d8e25276d725238ff279/src/library/tools/R/build.R#L342-L357
find_vignette_extras() comes from https://github.com/wch/r-source/blob/66fa35c1b7fe8993c1f4d8e25276d725238ff279/src/library/tools/R/build.R#L359-L373.

jimhester closed this as completed in

ff45628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment