Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relicensing devtools (wrap up) #2326

Closed
2 of 6 tasks
hadley opened this issue Feb 18, 2021 · 6 comments · Fixed by #2334
Closed
2 of 6 tasks

Relicensing devtools (wrap up) #2326

hadley opened this issue Feb 18, 2021 · 6 comments · Fixed by #2334

Comments

@hadley
Copy link
Member

hadley commented Feb 18, 2021

We are systematically re-licensing tidyverse and r-lib packages to use the MIT license, to make our package licenses as clear and permissive as possible. To do so, we need the approval of all copyright holders, which I have found by reviewing contributions from all all non-RStudio contributors.

Due to the maximum number of users who can be tagged in a post on GitHub, there were two issues (#2290, #2291) used to track re-licensing for ggplot2. This issue combines the remaining contributors who have not yet responded.

@AmundsenJunior, @karl-forner-quartz-bio, @mnel, @ncarchedi, @Paxanator, @yoni, would you permit us to re-license devtools with the MIT license? If so, please comment "I agree" below.

This was referenced Feb 18, 2021
@hadley
Copy link
Member Author

hadley commented Feb 18, 2021

@kforner I think this might be you?

@hadley
Copy link
Member Author

hadley commented Feb 18, 2021

Code contributed by @mnel no longer exists in devtools.

@hadley
Copy link
Member Author

hadley commented Feb 18, 2021

(Note to self — can't relicense until #2290 has been completed)

@yoni
Copy link
Contributor

yoni commented Feb 19, 2021

I agree

@kforner
Copy link

kforner commented Feb 19, 2021

@kforner I think this might be you?

Indeed. I agree.

@hadley
Copy link
Member Author

hadley commented Mar 31, 2021

Since folks haven't responed, I've carefully reviewed their contributions:

  • @AmundsenJunior ran styler, extracted duplicated code into a function, and linked a blog post from the README
  • @mnel changed one argument in a function call that is no longer included in devtools
  • @ncarchedi changed a function that no longer is included in devtools
  • @Paxanator adding a missing argument to a call

Since these contributions are small and mostly to code that no longer exists, I will proceed with re-licensing with lack of confirmation.

hadley added a commit that referenced this issue Mar 31, 2021
And remove R Core from authors list since all GPL code from R itself has been removed/rewritten.

Fixes #2326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants