Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build manual #2296

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Build manual #2296

merged 3 commits into from
Nov 13, 2020

Conversation

dmurdoch
Copy link
Contributor

@dmurdoch dmurdoch commented Nov 11, 2020

This simple change fixes the problem in issue #2295 by changing the default to manual = TRUE. The manual is only included when necessary, because pkgbuild::build just calls R CMD build, which makes the inclusion decision.

@dmurdoch
Copy link
Contributor Author

Instead of changing the default, I've changed it to add a note to the docs warning about CRAN issues. A similar note could be added to the docs for pkgbuild::build, but that causes Roxygen issues when importing the docs for devtools::build: see r-lib/roxygen2#1135 (comment).

@jimhester
Copy link
Member

Changing the documentation seems worthwhile, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants