Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface unused imports with check(cran = TRUE) #2461

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Aug 11, 2022

Closes #2459 (for R >= 4.2), which seems like a improvement worth having

Logically, this seems like it should close #2459 and yet I don't think it does? My local R version is not ideal for this at the moment, so I'm going to come back to this when I can experiment with it more easily. I'm on R 4.2 and yes this does what we want.

@jennybc jennybc requested a review from hadley August 11, 2022 22:01
@jennybc jennybc marked this pull request as ready for review August 11, 2022 22:36
@jennybc jennybc merged commit c9696a6 into main Aug 11, 2022
@jennybc jennybc deleted the surface-unused-imports branch August 11, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "_R_CHECK_PACKAGES_USED_IGNORE_UNUSED_IMPORTS_" = "false" to check(cran = TRUE)
2 participants