Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor package upkeep including add a website #122

Merged
merged 5 commits into from
May 14, 2024
Merged

Minor package upkeep including add a website #122

merged 5 commits into from
May 14, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented May 14, 2024

No description provided.

@hadley hadley requested a review from cderv May 14, 2024 13:43
Comment on lines +11 to +12
development:
mode: auto
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you switch to usual tidyverse / r-lib numbering ?

Not sure about the evolution of auto mode, but in R Markdown ecosystem with the other way to number with each release being x.y, and dev being x.y.z, this was not working.

So we have only a website built on main for rmarkdown and others.

I am ok with switching the version numbering, just so it is clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, plan is to switch to usual numbering.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it feels like it's probably time for 1.0.0 release.

@hadley hadley merged commit 166dd16 into main May 14, 2024
13 checks passed
@hadley hadley deleted the upkeep-2024 branch May 14, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants