Refine calling handlers #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
changed the title
Member
Author
|
@lionel let me know if you see a simple way to wrap |
lionel-
approved these changes
Jun 19, 2024
Co-authored-by: Lionel Henry <lionel.hry@gmail.com>
lionel-
reviewed
Jun 19, 2024
Comment on lines
+213
to
+215
| tryCatch(code, error = function(err) { | ||
| list(value = NULL, visible = FALSE) | ||
| }) |
Member
There was a problem hiding this comment.
It does seem like it would be easier to understand the return type if this was closer to the withVisible call
Member
Author
There was a problem hiding this comment.
I'll simplify this further after #153 since it turns out that we don't actually need to capture the visibility of the printed value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145