If error with zero-length reponse, set error message to "Empty Body" … #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…so that correct error is thrown. This is common with conditional requests where a 304 error is returned with an empty body to indicate that the resource hasn't been modified.
Currently,
gh
fails to return the correct error fromgh_error()
whenres
israw(0)
(an empty response body).This PR checks if
length(res) == 0
and if so initializesres = list(message = "Empty Body")
.I tried to create a test based on the above reprex, but couldn't quickly figure out how to setup httrmock. Hopefully the above reprex is a good start.