Make is_interactive() react to "rlang_interactive" option (#734)

* Make `is_interactive()` react to "rlang_interactive" option

Helpful for gargle's pseudo-OOB flow  in Google Colab

* Actually, I removed with mocks

* Add NEWS bullet

NEWS.md

@@ -1,5 +1,9 @@
 # httr (development version)
 
+* An internal helper that checks for an interactive session in the OOB flow now
+ honors the `"rlang_interactive"` global option, in case it's necessary to
+ declare the session to be interactive (enough) for OOB (@jennybc, #734).
+
 # httr 1.4.4
 
 * Fix intermittent failing test.

R/oauth-init.R

@@ -211,8 +211,12 @@ check_scope <- function(x) {
  paste(x, collapse = " ")
 }
 
-# Wrap base::interactive in a non-primitive function so that the call can be mocked for testing
-is_interactive <- function() interactive()
+# gargle needs to access (pseudo-)OOB flow from Google Colab, so we need to
+# be able to use the "rlang_interactive" option to signal that we are in
+# an environment that is interactive (enough) to complete this flow.
+is_interactive <- function() {
+ getOption("rlang_interactive") %||% interactive()
+}
 
 check_oob <- function(use_oob, oob_value = NULL) {
  if (!is.logical(use_oob) || length(use_oob) != 1) {

tests/testthat/test-oauth.R

@@ -111,13 +111,19 @@ test_that("oob must be a flag", {
 })
 
 test_that("can not use oob in non-interactive session", {
+ old <- options()
+ on.exit(options(old))
+ options(rlang_interactive = FALSE)
+
  expect_error(check_oob(TRUE), "interactive")
 })
 
 test_that("can not use custom oob value without enabling oob", {
  testthat::skip_if_not_installed("httpuv")
- with_mock(
- `httr:::is_interactive` = function() TRUE,
- expect_error(check_oob(FALSE, "custom_value"), "custom oob value")
- )
+
+ old <- options()
+ on.exit(options(old))
+ options(rlang_interactive = TRUE)
+
+ expect_error(check_oob(FALSE, "custom_value"), "custom oob value")
 })