RETRY options to ignore statuses and use try #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on #404 and some observations of my own I humbly submit this pull request that adds two new arguments to `RETRY`. `safe_statuses` is an integer vector of HTTP status codes that should not trigger a retry, overruling the result of a call to `http_error`. `use_try` is meant to handle the cases where curl signals an error (i.e., with `stop`) for transient situations such as a DNS lookup failure or a connection error. If this is set to `TRUE` then `RETRY` will call `try(request_perform(..))` and retry the operation if an error is signaled. Both parameters have sensible default values so that this change doesn’t introduce breaking changes and RETRY behaves as it did before if they are not overridden.
|
Let's discuss the API in the issue first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #404 and some
observations of my own I humbly submit this pull request that adds two
new arguments to
RETRY.safe_statusesis an integer vector of HTTP status codes that shouldnot trigger a retry, overruling the result of a call to
http_error.use_tryis meant to handle the cases where curl signals an error(i.e., with
stop) for transient situations such as a DNS lookupfailure or a connection error. If
use_tryis set toTRUEthenRETRYwill call
try(request_perform(..))and retry the operation if anerror is signaled.
Both parameters have sensible default values so that this change
doesn’t introduce breaking changes and RETRY behaves as it did before
if they are not overridden.