Fix basic auth on OAuth2 client credentials flow #485
Conversation
|
I finally managed to create a test using a dummy vimeo user. Phew! I have confirmed that the test fails without my proposed change. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@peterhartman for future reference, if you need me to look into a PR, including a brief summary of why it's important would be extremely helpful. It seems like this is a major frustration, but I read a lot of issues and it's easy for important stuff to get lost in the mix if it's not clearly labelled. |
There was a problem hiding this comment.
Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).
tests/testthat/test-oauth.R
Outdated
| @@ -25,6 +25,34 @@ test_that("oauth2.0 signing works", { | |||
| ) | |||
| }) | |||
|
|
|||
| test_that("oauth2.0 basic auth on client credentials works", { | |||
There was a problem hiding this comment.
I'm worried that this is too fragile to include in a test - it will break if vimeo is down. Can you please instead update the vimeo demo? (updating it to use oauth2.0, including changing the name of the file)
And remove corresponding test
|
Thanks for your help with this @peterhartman! |
It looks like
init_oauth2.0is not passinguse_basic_authonwards. I tried (and failed) to create a test for the client credentials flow using httpbin. I can't find a public API suitable for testing against unfortunately.