[docs] added RETRY() suggestion to api-packages vignette (fixes #638) #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just rebased this to |
|
I just merged |
|
This would fix #638 |
jameslamb
changed the title
|
It has been 1 year since this pull request was opened. Is there some additional information reviewers would like me to provide, or changes you'd like me to make? If reviewers here are not open to this pull request I'd also be happy to close it. Thank you for your time and consideration. |
|
This PR has been open for 20+ months with no interaction from maintainers, so I'm confident that there isn't interest in it. I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for an awesome project! I use
httrevery day, and recommend it to anyone who will listen.In this PR, I'd like to recommend an addition to the
api-packagesvignette. The vignette correctly mentions the importance of retrying failed requests and using exponential backoff w hen you do that, but it doesn't currently mention thathttr::RETRY()already has an implementation of that and should be used. I'd like to propose an explicit call-out forRETRY()in the vignette.For context, I'm working as part of a group at the Chicago R Collab conference this weekend, trying to improve the reliability of HTTP client packages on CRAN. We've found that many such clients use the single-shot
httr::<method>()functions, and I suspect that that's because package authors aren't familiar withRETRY(). We've documented a lot more about our thinking (and the contributions we've made to other projects so far) at chircollab/chircollab20#1.Thanks for your time and consideration!