-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable oauth_flow_auth_code
to parse URL for component code
and state
#326
Enable oauth_flow_auth_code
to parse URL for component code
and state
#326
Conversation
code
and state
oauth_flow_auth_code
to parse URL rather than component code
and state
oauth_flow_auth_code
to parse URL rather than component code
and state
oauth_flow_auth_code
to parse URL for component code
and state
Can you explain a bit more about how you expect the user experience to work? You'll forward them to a page that just says "copy this url"? If you're hosting that page, why is it any harder to copy in the javascript that would parse the components for them? |
Yeah, exactly!
It's a very static page, i.e.,: So, it would be ideal to not have to create javascript (our team doesn't have immediate expertise) and instead defer to the The current alternative is to have folks manually extract |
You don’t have to create JavaScript, you can just copy it onto that page? |
To clarify Michael's comment,
For our redirect, the Gitlab markdown file we're using is a static page that's essentially a page of documentation within a larger repo, so it isn't a full site where we are able to interact with the JavaScript and have it handle the parsing |
Ah, it's not even an HTML page. |
thank you, @hadley ! |
If a
redirect_uri
is a static redirect i.e., does not parse results via Javascript (as done in https://www.tidyverse.org/google-callback (parsing source code), users currently need to manually parsecode
andstate
from the URL itself, which is time consuming (and error prone).Rather, it would be more efficient to just copy the URL itself, rather than require users to host a site that parses the result.
@hadley this suggested change is based on our convo during the Posit conf workshop!