Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PIPE to infix_metadata #1793

Merged
merged 4 commits into from
Dec 5, 2022
Merged

add PIPE to infix_metadata #1793

merged 4 commits into from
Dec 5, 2022

Conversation

AshesITR
Copy link
Collaborator

@AshesITR AshesITR commented Dec 5, 2022 •
edited
Loading

fixes #1792

@AshesITR AshesITR linked an issue Dec 5, 2022 that may be closed by this pull request
infix_spaces_linter() should support native pipe #1794
Closed
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022 •
edited
Loading

Codecov Report

Merging #1793 (70568e4) into main (fc76887) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1793   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files         110      110           
  Lines        4692     4692           
=======================================
  Hits         4640     4640           
  Misses         52       52
Impacted Files Coverage Δ
R/infix_spaces_linter.R 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MichaelChirico
Copy link
Collaborator

great find! I swear I thought native pipe was handled already...

IndrajeetPatil
IndrajeetPatil approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@IndrajeetPatil IndrajeetPatil merged commit c814159 into main Dec 5, 2022
@AshesITR AshesITR deleted the feature/1792-indent-pipe branch December 5, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IndrajeetPatil IndrajeetPatil IndrajeetPatil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

infix_spaces_linter() should support native pipe indentation_linter() should support native pipe
4 participants
@AshesITR @codecov-commenter @MichaelChirico @IndrajeetPatil