Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Sys.unsetenv() to default_undesirable_functions #2192

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Adds Sys.unsetenv() to default_undesirable_functions #2192

merged 2 commits into from
Sep 19, 2023

Conversation

IndrajeetPatil
Copy link
Collaborator

closes #1762

@MichaelChirico
Copy link
Collaborator

NEWS?

@codecov-commenter
Copy link

Codecov Report

Merging #2192 (cd4471b) into main (8fe5e0f) will not change coverage.
The diff coverage is n/a.

❗ Current head cd4471b differs from pull request most recent head 61d5294. Consider uploading reports for the commit 61d5294 to get more accurate results

@@           Coverage Diff           @@
##             main    #2192   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         113      113           
  Lines        5153     5153           
=======================================
  Hits         5135     5135           
  Misses         18       18

@MichaelChirico MichaelChirico merged commit 1183f15 into main Sep 19, 2023
@MichaelChirico MichaelChirico deleted the f1762 branch September 19, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shouldn't Sys.unsetenv() be added to default_undesirable_functions?
3 participants
@IndrajeetPatil @MichaelChirico @codecov-commenter