Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split comment_linters into two separate files for each linter #2437

Merged
merged 6 commits into from
Dec 14, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Towards #2047

This is for consistency with the rest of the code base, and to match the style of R/$FILE being tested in tests/testthat/test-$FILE.

I followed https://stackoverflow.com/a/44036771/3576984 to try and ensure code history is retained going forward.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (317429e) 98.54% compared to head (ea2bfd3) 98.54%.

❗ Current head ea2bfd3 differs from pull request most recent head 5aaf8a1. Consider uploading reports for the commit 5aaf8a1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2437   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         125      126    +1     
  Lines        5631     5633    +2     
=======================================
+ Hits         5549     5551    +2     
  Misses         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants