Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved script generating the .lintr file, fixes #268 #344

Merged
merged 3 commits into from
Sep 26, 2019
Merged

Improved script generating the .lintr file, fixes #268 #344

merged 3 commits into from
Sep 26, 2019

Conversation

Guillawme
Copy link
Contributor

There is no change to the package code, I simply edited README.md to propose a better script for automatically generating a .lintr file.

With this script, the generated .lintr file will not cause the problem described in #268.

@Guillawme Guillawme requested a review from jimhester as a code owner August 23, 2018 19:08
@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1f2cb45). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #344   +/-   ##
========================================
  Coverage          ?   85.6%           
========================================
  Files             ?      41           
  Lines             ?    2132           
  Branches          ?       0           
========================================
  Hits              ?    1825           
  Misses            ?     307           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2cb45...285528e. Read the comment docs.

@jimhester
Copy link
Member

Great work, this package is now better thanks to you!

Thanks!! You are da bomb!

@jimhester jimhester merged commit 8288366 into r-lib:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants