Simplify line length #734
Merged
Simplify line length #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's safe to run this one on the full file only. `nchar` on 300K line script still takes <.1 seconds
AshesITR
reviewed
Feb 3, 2021
|
I think this is a more general issue... in my mind the which if we go to column+1 will look odd for that use case... vs the use case you have in mind, which is to land the cursor just after the lint when using it with the rstudio plugin. Can we make these two use cases work together better? |
|
How would the highlight look if the range is left in tact (1 to nchar) and the column_number updated? |
|
Oh sorry, I misunderstood. IIUC the |
|
Thats fine by me. |
AshesITR
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.